Traneptora/FFmpeg
1
Fork 0
forked from FFmpeg/FFmpeg
Code Pull requests Activity

libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

Browse source 
While reading the filename tag, it may return a EOF and we are still
copying the file with uninitialized value.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Thierry Foucu 2020-08-19 15:51:02 -07:00 • committed by Michael Niedermayer
parent a606e3b339
commit 36f7b83568
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libavformat/r3d.c
View file

@ -56,6 +56,7 @@ static int r3d_read_red1(AVFormatContext *s)
R3DContext *r3d = s->priv_data;
char filename[258];
int tmp;
int ret;
int av_unused tmp2;
AVRational framerate;
@ -97,7 +98,9 @@ static int r3d_read_red1(AVFormatContext *s)
r3d->audio_channels = avio_r8(s->pb); // audio channels
av_log(s, AV_LOG_TRACE, "audio channels %d\n", tmp);
avio_read(s->pb, filename, 257);
ret = avio_read(s->pb, filename, 257);
if (ret < 257)
return ret < 0 ? ret : AVERROR_EOF;
filename[sizeof(filename)-1] = 0;
av_dict_set(&st->metadata, "filename", filename, 0);