Traneptora/FFmpeg
1
Fork 0
forked from FFmpeg/FFmpeg
Code Pull requests Activity

lavc/videotoolboxenc: fix enabling low-latency encode

Browse source 
Use CFDictionarySetValue to enable low-latency encoding mode.
Since the key is a type of "EncoderSpecification", instead of
"CompressionProperty".

Signed-off-by: xufuji456 <839789740@qq.com>
Signed-off-by: Rick Kern <kernrj@gmail.com>
This commit is contained in:
xufuji456 2023-06-21 17:38:33 +08:00 • committed by Rick Kern
parent 8a6d3482de
commit 5930d397ef
1 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libavcodec/videotoolboxenc.c
View file

@ -1536,17 +1536,6 @@ static int vtenc_create_encoder(AVCodecContext *avctx,
} }
} }
// low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode
if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) {
status = VTSessionSetProperty(vtctx->session,
compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
kCFBooleanTrue);
if (status) {
av_log(avctx, AV_LOG_ERROR, "Error setting low latency property: %d\n", status);
}
}
if ((avctx->flags & AV_CODEC_FLAG_CLOSED_GOP) != 0) { if ((avctx->flags & AV_CODEC_FLAG_CLOSED_GOP) != 0) {
set_encoder_property_or_log(avctx, set_encoder_property_or_log(avctx,
compat_keys.kVTCompressionPropertyKey_AllowOpenGOP, compat_keys.kVTCompressionPropertyKey_AllowOpenGOP,
@ -1690,6 +1679,13 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
} }
#endif #endif
// low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode
if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) {
CFDictionarySetValue(enc_info,
compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
kCFBooleanTrue);
}
if (avctx->pix_fmt != AV_PIX_FMT_VIDEOTOOLBOX) { if (avctx->pix_fmt != AV_PIX_FMT_VIDEOTOOLBOX) {
status = create_cv_pixel_buffer_info(avctx, &pixel_buffer_info); status = create_cv_pixel_buffer_info(avctx, &pixel_buffer_info);
if (status) if (status)