From 7da7d269b8409b2533f4434ab10a197d5726569e Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Mon, 2 Mar 2015 14:19:41 +0100 Subject: [PATCH] ffplay: Switch to show waves mode if allocation/init of RDFT fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes null pointer dereference Found-by: Paweł Reviewed-by: Marton Balint Signed-off-by: Michael Niedermayer --- ffplay.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index 8140dd9645..94c7ed45d1 100644 --- a/ffplay.c +++ b/ffplay.c @@ -1247,7 +1247,10 @@ static void video_audio_display(VideoState *s) s->rdft_bits = rdft_bits; s->rdft_data = av_malloc_array(nb_freq, 4 *sizeof(*s->rdft_data)); } - { + if (!s->rdft || !s->rdft_data){ + av_log(NULL, AV_LOG_ERROR, "Failed to allocate buffers for RDFT, switching to waves display\n"); + s->show_mode = SHOW_MODE_WAVES; + } else { FFTSample *data[2]; for (ch = 0; ch < nb_display_channels; ch++) { data[ch] = s->rdft_data + 2 * nb_freq * ch;